Re: [Nautilus-list] [PATCH]: avoid re-layouting when it's not needed.

Maciej Stachowiak <mjs noisehavoc org> writes:

> On 17Jun2001 12:58PM (+0200), Yoann Vandoorselaere wrote:
> > 
> > On directory load, we do relayout several time before it's needed
> > (before any file get added or changed). In fact, in this case, the
> > files_changed signal should only be hooked after finish_loading is
> > called (when the view is loaded and we are starting monitoring the
> > directory), and disconnected as soon as the directory load is done.
> > 
> > This work fine on my local tree, and seem to help with latency.
> > 
> Darin said he was worried about this change introducing bugs. Can you
> describe what testing you did to make sure it doesn't, 

First can you comfirm me that a files_changed signal can and should
be caught by the directory view between two directory load...

I know the files_added one is used, not sure about files_changed...

But I might have a better fix soon that would avoid making this risky
change... I'll keep you informed...

> and also what
> testing you did to show that this change really improves performance?

I observed that when loading a directory, we are losting time in doing
re-layouting even *before* any file get added. 

The reason is the emission of the files_changed signal which trigger
display functions...

Yoann Vandoorselaere | "Programming is a race between programmers, who try and
MandrakeSoft         | make more and more idiot-proof software, and universe,
                     | which produces more and more remarkable idiots. Until
                     | now, universe leads the race"  -- R. Cook

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]