[Nautilus-list] Re: [Nautilus-list] Pressing å,ä or ö crashes nautilus.



On Friday, June 1, 2001, at 04:50  AM, ISO-8859-1 wrote:

Nautilus (HEAD) crashes when you're pressing ,  or .
(3 swedish characters)

This patch fixes it.

Have i written it correct, and may i commit?

Thanks for pointing this out! I really appreciate the help.

Your fix is insufficient, though. You have fixed the assert, which gets rid of the core dump. But you didn't fix the almost-identical code that follows, which has the same bug.

Index: libnautilus-private/nautilus-icon-container.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-icon-container.
c,v
retrieving revision 1.213
diff -u -r1.213 nautilus-icon-container.c
--- libnautilus-private/nautilus-icon-container.c	2001/05/31 16:05:40	1.213
+++ libnautilus-private/nautilus-icon-container.c	2001/06/01 11:47:41
@@ -2170,7 +2170,7 @@

 		/* Require the match pattern to already be lowercase. */
 		g_assert (tolower ((guchar) match_state->name[match_length])
-			  == match_state->name[match_length]);
+			  == ((guchar)match_state->name[match_length]));
 			
if (tolower ((guchar) name[match_length]) != match_state->name[match_length]) {
 			break;

I'll check in a corrected fix right away.

    -- Darin




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]