Re: [Nautilus-list] Segfault when dragging icons

On Thursday, July 19, 2001, at 11:51  AM, Alex Larsson wrote:

Ok. Here is a patch that i believe fixes this problem. It is sorta hard to
verify since the actuall bug is hard to trigger though:

Index: libnautilus-private/nautilus-icon-container.c
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-icon-container.
retrieving revision 1.214
diff -u -p -r1.214 nautilus-icon-container.c
--- libnautilus-private/nautilus-icon-container.c	2001/06/01 15:19:58	1.214
+++ libnautilus-private/nautilus-icon-container.c	2001/07/19 18:44:01
@@ -3594,7 +3594,8 @@ nautilus_icon_container_clear (NautilusI
 	details->icons = NULL;
 	g_list_free (details->new_icons);
 	details->new_icons = NULL;
+	details->drop_target = NULL;
 	nautilus_icon_container_update_scroll_region (container);

Yes. Looks great. Please commit.

I hunted for places that deleted icons without using icon_destroy after your initial report and wasn't able to find a place. This is clearly it!

    -- Darin

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]