Re: [Nautilus-list] eel gcc'isms patch

[Laszlo PETER <Laszlo Peter ireland sun com>]

Darin Adler wrote:
> 
> On 12/7/01 12:24 PM, "Brett Kail" <junkaddr hotmail com> wrote:
> 
> > -    return art_irect_empty (&ab_union) ? eel_art_irect_empty : ab_union;
> > +    if (art_irect_empty (&ab_union)) {
> > +        return eel_art_irect_empty;
> > +    } else {
> > +        ab_union;
> > +    }
> > }
> >
> > Perhaps it archived incorrectly, but it appears that there should be a
> > 'return' before the 'ab_union' in the else.  Doesn't this patch cause a 'not
> > all control paths return a value' warning?  I apologize if I am misreading
> > this patch.
> 
> You're right. It's missing a return statement. I'll be fixing this now (I
> was out for a while) because it prevents me from compiling eel.

Sorry for that.  I do compile every patch before I post them, but strangely
enough this compiles without even a warning with my C compiler.  I'll submit
a bug report agains it.

Laca