[Nautilus-list] eel gcc'isms patch

["Brett Kail" <junkaddr hotmail com>]

Hello,

I usually only read nautilus-list via archives, but I saw a patch from
Laszlo PETER that was approved that contained the following change to
eel/eel-art-extensions.c

@@ -456,7 +460,11 @@

	art_irect_union (&ab_union, &rectangle_a, &rectangle_b);

-	return art_irect_empty (&ab_union) ? eel_art_irect_empty : ab_union;
+	if (art_irect_empty (&ab_union)) {
+		return eel_art_irect_empty;
+	} else {
+		ab_union;
+	}
}

Perhaps it archived incorrectly, but it appears that there should be a 
'return' before the 'ab_union' in the else.  Doesn't this patch cause a 'not 
all control paths return a value' warning?  I apologize if I am misreading 
this patch.

-Brett

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp