Re: [Nautilus-list] PATCH: eel gcc'isms
- From: Darin Adler <darin bentspoon com>
- To: <Laca ireland sun com>, Nautilus list <nautilus-list eazel com>
- Subject: Re: [Nautilus-list] PATCH: eel gcc'isms
- Date: Thu, 06 Dec 2001 12:23:54 -0800
Overall the changes look great. Feel free to commit after addressing this
one minor point:
On 12/6/01 11:59 AM, "Laszlo PETER" <Laszlo Peter ireland sun com> wrote:
> -EelDimensions
> +const EelDimensions
> eel_gdk_pixbuf_get_dimensions (const GdkPixbuf *pixbuf)
> {
> /* Access the dimensions of a pixbuf. */
> -EelDimensions eel_gdk_pixbuf_get_dimensions (const
> GdkPixbuf *pixbuf);
> +const EelDimensions eel_gdk_pixbuf_get_dimensions (const
> GdkPixbuf *pixbuf);
These are acceptable, I guess, but they do not look like great changes to
me. Can you omit these and fix problems related to these another way?
-- Darin
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]