Re: [Nautilus-list] Nautilus Performance Analysis

[Alex Larsson <alexl redhat com>]

On Tue, 14 Aug 2001, Darin Adler wrote:

> Such a test is completely inappropriate for g_return_val_if_fail, if it 
> results in I/O. We ought to fix this egregious mistake even if we also 
> solve the real problem with your patch. The best fix is to simply remove 
> this line.

Here is another one:

Index: eel/eel-font-manager.c
===================================================================
RCS file: /cvs/gnome/eel/eel/eel-font-manager.c,v
retrieving revision 1.13.2.2
diff -u -p -r1.13.2.2 eel-font-manager.c
--- eel/eel-font-manager.c	2001/07/16 16:02:18	1.13.2.2
+++ eel/eel-font-manager.c	2001/08/14 20:28:31
@@ -1347,7 +1347,6 @@ eel_font_manager_get_bold (const char *p
 	FindData data;
 
 	g_return_val_if_fail (eel_strlen (plain_font) > 0, NULL);
-	g_return_val_if_fail (eel_font_manager_file_is_scalable_font (plain_font), NULL);
 
 	ensure_local_font_table ();