Re: [Nautilus-list] nautilus-adapter UIContainer patch

[Maciej Stachowiak <mjs eazel com>]

Martin Baulig <martin home-of-linux org> writes:

> Hi guys,
> 
> there is a problem with the way the nautilus-adapter handles
> the Bonobo_UIContainer at the moment:
> 
> * nautilus_view_frame_set_to_component() passes the component
>   to nautilus_component_adapter_factory_create_adapter(), but at
>   this time it isn't bound to a BonoboControlFrame yet (because
>   Nautilus doesn't even know whether it's a Control or an Embeddable).
> 
> * the nautilus-adapter calls bonobo_control_get_remote_ui_container()
>   which will always return CORBA_OBJECT_NIL until the component has
>   been bound to a ControlFrame.
> 
> The following patch adds an additional Bonobo_UIContainer arguent to
> nautilus_component_adapter_factory_create_adapter() to fix this:
>

Wow, I never even thought of fixing it this way. Thanks for the
patch. The problem we have here is actually a more general problem for
any Controls or Embeddables that embed other Controls or
Embeddables. Let me talk to michael about it first, if he does not
decide to fix the issue in Bonobo, feel free to commit this patch and
close bugs 3650 and 3177 (the bugs we have open on this issue).

 
> ====
> 2000-10-14  Martin Baulig  <baulig suse de>
> 
> 	* libnautilus-adapter/nautilus-adapter-factory.idl (create_adapter):
> 	Added Bonobo::UIContainer argument.
> 	* components/adapter/nautilus-adapter-factory-server.c
> 	(impl_Nautilus_ComponentAdapterFactory_create_adapter): Added
> 	`const Bonobo_UIContainer' argument.
> 	* components/adapter/nautilus-adapter.c (nautilus_adapter_new): Added
> 	`Bonobo_UIContainer' argument and use it as second argument in the call
> 	to nautilus_adapter_embed_strategy_get().
> 	* src/nautilus-component-adapter-factory.c
> 	(nautilus_component_adapter_factory_create_adapter): Added
> 	`Bonobo_UIContainer' argument.
> 	* src/nautilus-view-frame.c (nautilus_view_frame_set_to_component): Pass
> 	nautilus_component_adapter_factory_create_adapter() our Bonobo_UIContainer.
> 
> ===
> 
> Here's the patch:
> 
> 
> 
> 
> 
> -- 
> Martin Baulig
> martin gnome org (private)
> baulig suse de (work)