Re: [RFE][PATCH] Display free space on device in panels

Hi Leonard,

On Thu, 2006-05-18 at 23:42 +0200, Leonard den Ottolander wrote:
> On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote:
> > Btw if anyone on this list wants to share his thoughts on this patch - now 
> > is the time.
> Personally I don't like the highlighting of the free space indicator. I
> find it rather distracting. It suffices that the top of the panel is
> highlighted, no need to highlight that info for the active panel. IMO
> the conditional attrset (REVERSE_COLOR) etc should be removed.

I noticed your reply related to the free space widget highlighting also
on bugzilla. I my opinion it makes the look-and-feel of mc more
consistent when the free space widget is highlighted. The reasons are:

1) Everything what is written directly to the panel frame is highlighted
   (current working directory, directory history widget).

2) You are sure that you are looking at the correct free space in the
   panel you are working in. When it wouldn't be highlighted, you need
   to look up at the panel title to be sure whether it's active since
   the the highlighted widgets are on top of the panel. This may save
   you one eye movement ;)

It seems that we need a feedback from someone else whether to highlight
or not. If more users are unhappy with the highlighting, I have no
problem with removing it. The current version of the patch is applied in
FC5 if you want to see how it looks like (highlighted version).


Jindrich Novy <jnovy redhat com>

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]