Re: [PATCH] Re: Segfault on loading of non existent syntax file
- From: "Pavel Tsekov" <ptsekov gmx net>
- To: Leonard den Ottolander <leonard den ottolander nl>
- Cc: mc-devel gnome org
- Subject: Re: [PATCH] Re: Segfault on loading of non existent syntax file
- Date: Tue, 28 Mar 2006 09:58:39 +0200 (MEST)
> On Mon, 2006-03-27 at 21:57 +0200, Leonard den Ottolander wrote:
> > doesn't this cause a memory leak? Or is that memory freed
> > elsewhere?
>
> Last statement in the skipped edit_free_syntax_rules() is a
> syntax_g_free(edit->rules). I guess we need a free.
You guess .. I guess you should stop guessing and start reading code .
> The zeroing by g_malloc0 only obscures possible code issues so I'd vote
> against it.
Yeah ? And your patch does not obfuscate the matter even more by "fixing"
the problem in a place which has nothing to do with this matter ?
--
Echte DSL-Flatrate dauerhaft für 0,- Euro*!
"Feel free" mit GMX DSL! http://www.gmx.net/de/go/dsl
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]