Re: redundant code in ftpfs?
- From: Pavel Tsekov <ptsekov gmx net>
- To: Arpi <arpi mplayerhq hu>
- Cc: mc-devel gnome org
- Subject: Re: redundant code in ftpfs?
- Date: Mon, 6 Mar 2006 17:34:36 +0200
On Sun, 5 Feb 2006, Arpi wrote:
> p = ftpfs_translate_path (me, super, remote_path);
> if (ftpfs_chdir_internal (me, super, p) != COMPLETE) {
> ...
> }
> g_free (p);
>
> the ftpfs_translate_path() call and the 'p' pointer are redundant here,
> as ftpfs_translate_path is also called from inside ftpfs_chdir_internal()
> on the p parameter. so now it's done twice, which is redundant, and
> may be a problem too...
I have removed the extra call to ftpfs_translate_path() and the related
code from the CVS version of ftpfs.c.
Thanks!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]