Re: [patch] allow seeking in linear files

[Jindrich Makovicka <makovick kmlinux fjfi cvut cz>]

Pavel Tsekov wrote:
> On Fri, 20 Jan 2006, Jindrich Makovicka wrote:
> 
> 
>>this patch adds an ability to seek in linear files before the first read
>>operation. It is achieved by postponing the actual opening to
>>linear_read() call. The main reason of this is to make ftpfs' reget
>>function work again.
>>
>>Modification for fish to work with this change, and a minor fix of the
>>ftpfs copy status display is included.
> 
> 
> I've commited your patch with minor changes. Next time, please, provide
> a changelog.
> 
> Thanks!

Sorry, but I just found that one of your changes breaks linear open on
random access files. Now, eg. the content of tar files is unaccessible.
The attached patch should fix it.

Regards,
-- 
Jindrich Makovicka

Index: direntry.c
===================================================================
RCS file: /sources/mc/mc/vfs/direntry.c,v
retrieving revision 1.120
diff -u -r1.120 direntry.c
--- direntry.c	25 Jan 2006 14:04:27 -0000	1.120
+++ direntry.c	28 Jan 2006 14:04:03 -0000
@@ -780,7 +780,8 @@
 	if (MEDATA->linear_start) {
 	    print_vfs_message (_("Starting linear transfer..."));
 	    fh->linear = LS_LINEAR_PREOPEN;
-	} else {
+	} else if ((MEDATA->fh_open)
+	       && (MEDATA->fh_open (me, fh, flags, mode))) {
 	    g_free (fh);
 	    ERRNOR (ENOSYS, NULL);
 	}