Re: accels busted



Oswald Buddenhagen wrote:
one of the recent commits broke the alt-<letter from main menu>
accelerators in mcedit.
a related thing that always annoyed me: once you are in the menu (after
f9), pressing just the unmodified letter should open the respective
submenu as well.

I had not checked the patch that introduced the user-defined key bindings enough. To fix this issue, I suggest the appended patch to be applied.

Roland
Index: editkeys.c
===================================================================
RCS file: /cvsroot/mc/mc/edit/editkeys.c,v
retrieving revision 1.18
diff -u -p -r1.18 editkeys.c
--- editkeys.c	10 Aug 2005 16:47:44 -0000	1.18
+++ editkeys.c	28 Jan 2006 01:22:14 -0000
@@ -262,23 +262,9 @@ edit_translate_key (WEdit *edit, long x_
 	continue;
     if (key_map[i].key != 0) {
 	command = key_map[i].command;
-	goto fin;
     }
 
-    /* Function still not found for this key, so try macros */
-    /* This allows the same macro to be
-       enabled by either eg "ALT('f')" or "XCTRL('f')" or "XCTRL('a'), 'f'" */
-
-    if (x_key & ALT (0)) {	/* is an alt key ? */
-	command = CK_Macro (x_key - ALT (0));
-	goto fin;
-    }
-    if (x_key < ' ') {		/* is a ctrl key ? */
-	command = CK_Macro (x_key);
-	goto fin;
-    }
   fin:
-
     *cmd = command;
     *ch = char_for_insertion;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]