Re: Big patch for mcview

[Jindrich Makovicka <makovick kmlinux fjfi cvut cz>]

Roland Illig wrote:
> Pavel Tsekov wrote:
>
> > First of all - this patch could have been much smaller and thus easier to
> > review/understand. 25 % (line 666 to the end) of the patch are hunks 
> > which
> > do the following:
> >
> >   get_byte => view->get_byte
> >
> > Well, simply keeping get_byte () and calling view->get_byte from within
> > would have been much nicer. Also you could have made our lives easier if
> > you have moved most of the "new" functions that you have introduced to
> > the end of the file - this way it would be much easier to read the patch.
>
>
> Sorry for these. I had uploaded an old version of the patch. An improved 
> patch is available: http://www.roland-illig.de/tmp/viewer-try2.patch

Crashes when switching between viewer modes. To reproduce, use F3 on a 
jpg/mp3/whatever (assuming you have mpg123, ImageMagick or other 
corresponding viewer), press F8 to display raw, then press F4 => sig11.

Regards,
--
Jindrich Makovicka