Re: Fw: [patch] Synchronization of the panels (fwd)

[Pavel Tsekov <ptsekov gmx net>]

Hello Andrey,

On Wed, 16 Mar 2005, Siver Andrey wrote:

> > ----- Original Message -----
> > From: "Miguel de Icaza" <miguel ximian com>
> > To: "Pavel Tsekov" <ptsekov gmx net>
> > Cc: "MC dev" <mc-devel gnome org>
> > Sent: Saturday, February 26, 2005 7:40 PM
> > Subject: Re: [patch] Synchronization of the panels (fwd)
> >
> >
> > > Hello,
> > >
> > > The patch still needs a lot of work, for example, why do we have an
> > > include file at all with the code?  (The core of the code lives in
> > > sync.inc).
> >
> > It's not a problem if it's the last problem (it's easy to embed sync.inc
> > straight into main.c).

Well, it is even easier to create a new set of files (.h and .c) devoted
to this new feature and then patch the Makefile.am files to include the
new module in the build.

> > > Configure patches, fall back patches are missing as well.
> >
> > I would like to ask somebody to update configure scripts (WITH_SYNC need
> to
> > be defined if kernel version >= 2.4. If it's not defined - the patch gives
> > nothing new, so I do not understand what do you mean by "fall back
> > patches").
> >
> > Is anybody ready to do it?

It must be you . You can get some help/advice in the process of reviewing
your patch - but do not expect others to do your job.