Re: [PATCH] Choose syntax
- From: Roland Illig <roland illig gmx de>
- To: Leonard den Ottolander <leonard den ottolander nl>
- Cc: MC Devel <mc-devel gnome org>
- Subject: Re: [PATCH] Choose syntax
- Date: Tue, 12 Jul 2005 08:52:05 +0200
Leonard den Ottolander wrote:
Hi,
[...]
- Blatantly ignoring any suggestion to use NULL, TRUE or FALSE.
[...]
+#include <config.h>
+#include "edit.h"
+#include "syntax.h"
+#include "../src/wtools.h"
- Blatantly ignoring any suggestions to follow common #include practice.
+void
+edit_syntax_dialog () {
... as well as any suggestions to declare proper function prototypes ...
+ char *old_syntax_type;
+ int old_auto_syntax, syntax;
... as well as any suggestions to use gboolean when a variable is
clearly meant to be of a boolean type ...
+/* This list could be allocated here dynamically as we don't know it's size yet */
... as well as spelling errors. I don't care about them.
;)
Roland
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]