Re: [PATCH] Choose syntax

Leonard den Ottolander wrote:
- Blatantly ignoring any suggestion to use NULL, TRUE or FALSE.
+#include <config.h>
+#include "edit.h"
+#include "syntax.h"
+#include "../src/wtools.h"

- Blatantly ignoring any suggestions to follow common #include practice.

+edit_syntax_dialog () {

... as well as any suggestions to declare proper function prototypes ...

+    char *old_syntax_type;
+    int old_auto_syntax, syntax;

... as well as any suggestions to use gboolean when a variable is clearly meant to be of a boolean type ...

+/* This list could be allocated here dynamically as we don't know it's size yet */

... as well as spelling errors. I don't care about them.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]