Re: large device major/minor numbers not supported


On Fri, Jan 21, 2005 at 11:18:38AM +0100, Roland Illig wrote:

> I tested my patch on NetBSD and Solaris. Hope it works for you, too.

Works under Linux, but:

Now only up to 5 characters are used for "number,number" notation, e.g.
"55,55" is displayed as such but "55,110" is replaced by "[dev]". It's
caused by an off-by-one error in ilog10(), "digits" should be initialized to
0 instead of 1, since you immediately increment it.

On the other hand, I couldn't manage to figure out when that "~~~" string is
used, I always get "number,number" or "[dev]". Maybe the "if" before this
"~~~" wanted to check for maj_used_digits instead of maj_digits? But I don't
really like the idea of having two completely different ways to abbreviate
the stuff.

Also, please consider using _("[dev]") instead of simply "[dev]".

Apart from these, the patch looks okay and I hope that (after fixing these)
it will be commited to HEAD. :-)) Thanks!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]