Re: Dropping mmap from the virtual file system



Leonard den Ottolander wrote:
Hi Roland,


I would like to drop the mmap() and munmap() methods from the vfs code.


Why?

To make the source code of mc smaller and better understandable. For the virtual file system, it nearly makes no sense to provide an mmap() method, as most of the filesystems would have to implement it using read() anyways.

At least, no vfs other than localfs currently implements the mmap() calls.

Another thing is that mmap() does not work reliably on FreeBSD when using it with files in /proc. The Midnight Commander crashes then with a SIGBUS error.

There would be two methods less that a vfs implementor has to think about.

Roland



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]