Re: [patch] Synchronization of the panels (fwd)

[Pavel Tsekov <ptsekov gmx net>]

Hello,

This is an updated version of the dnotify patch from Andrey Siver.

--- Begin Message ---

• From: "Siver Andrey" <siver sirius ihep su>
• To: "Pavel Tsekov" <ptsekov gmx net>
• Subject: Re: [patch] Synchronization of the panels
• Date: Fri, 25 Feb 2005 11:25:58 +0300

Dear maintainer,

I agree with you.
I update the patch in following ways:
1) Try to format properly;
2) Add feature conditions (with WITH_SYNC macro-parameter). So, now it's
possible to exclude the code in case of kernel version < 2.4.X at
compilation time. I would like to ask somebody to update configure scripts
processing this;
3) Add error processing (with sync_err global variable);
4) Some other changes.


Regards,

Andrey

-------

----- Original Message ----- 
From: "Pavel Tsekov" <ptsekov gmx net>
To: "Siver Andrey" <siver sirius ihep su>
Cc: <mc-devel gnome org>
Sent: Tuesday, February 22, 2005 1:11 PM
Subject: Re: [patch] Synchronization of the panels


> Hello Andrey,
>
> On Tue, 22 Feb 2005, Siver Andrey wrote:
>
> > Hi,
> >
> > Please consider my patch to synchronize the panels with hard drives
state.
>
> I really appreciate the fact that you decided to implement this
> most interesting feature in mc, but your patch is far from being complete.
> First of all your code is not properly formatted - please take a look at
> MC's source files and try to indent the code the same way. Next and more
> important your patch lacks any configure checks - as you have already
> mentiond in your previous post, regarding this new feature, the directory
> notification is available only on 2.4.x and up. Also your code has limited
> if any error checking - the return values of calls like open () and fcntl
> () should be considered.
>
> Please, update your code and post it again. If you require any help don't
> hesitate to ask on the mailing list. I'm also willing to help integrate
> this feature into MC.
>
>
>

Attachment: sync.inc
Description: Binary data

Attachment: main.c.diff
Description: Binary data

Attachment: dialog.c.diff
Description: Binary data

--- End Message ---