Re: [PATCH]: Add support for changing drives in Cygwin




On Thu, 16 Sep 2004, Oswald Buddenhagen wrote:

> On Thu, Sep 16, 2004 at 01:19:17PM +0200, Pavel Tsekov wrote:
> > +++ src/drive.c	2004-09-16 12:36:52.222032000 +0200
> > +inline void
> > +drive_cmd_left (void)
> > +{
> > +    drive_cmd (left_panel);
> > +}
> > +
> > +++ src/drive.h	2004-09-16 09:42:52.049801600 +0200
> > +inline void drive_cmd_left (void);
> >
> guess what's wrong with this ...

Good catch. It's actually pointless since it inlines only in the
current unit where it is not used at all. Or maybe this is not
what you mean ? In fact there is no point to inline at all since
those functions are called through pointers.

I'll resubmit the patch tommorw. Thanks!

Pavel Tsekov



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]