Re: Current code snapshot

[Leonard den Ottolander <leonard den ottolander nl>]

Hi Roland,

On Thu, 2004-09-02 at 13:52, Roland Illig wrote:
> yes, you're right. I have just returned from another part of holidays 
> and seen the mail with the error message.

I just received an email from Jakub Jelinek which includes a couple of
patches some of which I will propose for inclusion later (Pavel Sh.,
more patches! :)

But one fixes (all?) warnings from today's CVS. I haven't taken a look
at it's content, I leave that to you (Roland).

> Well, perhaps it's better if I 
> publish my patches in a public directory or in the Savannah bug tracking 
> system.

What I understood from Pavel Sh. Savannah lets only maintainers edit
bugs. This means I would have to become a maintainer just to close bugs
there. Not sure if Pavel Roskin can change anything about this behaviour
or that he is bound by the policies of the Savannah administrators, but
this behaviour is not very practical. Bugzilla editors should just be a
different kind of developers, that do not necessarily get CVS commit
access. Maybe it is time to look for another solution to replace
Savannah *Bugzilla*, but more on this in a later mail.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research

--- mc/edit/editcmd.c.jj	2004-09-02 11:08:50.000000000 +0200
+++ mc/edit/editcmd.c	2004-09-02 18:10:08.595679268 +0200
@@ -388,7 +388,7 @@ void menu_save_mode_cmd (void)
 	{quick_label, 22, DLG_X, 4, DLG_Y, N_("Extension:"), 0,
 	 0, 0, 0, "savemext"},
 	{quick_radio, 4, DLG_X, 3, DLG_Y, "", 3,
-	 0, &save_mode_new, str, "t"},
+	 0, &save_mode_new, (char **) str, "t"},
 	NULL_QuickWidget};
     static QuickDialog dialog =
     {DLG_X, DLG_Y, -1, -1, N_(" Edit Save Mode "), "[Edit Save Mode]",
--- mc/edit/editwidget.c.jj	2003-10-29 09:54:48.000000000 +0100
+++ mc/edit/editwidget.c	2004-09-02 18:12:41.562683354 +0200
@@ -127,7 +127,7 @@ edit_adjust_size (Dlg_head *h)
     WEdit *edit;
     WButtonBar *edit_bar;
 
-    edit = (WEdit *) find_widget_type (h, edit_callback);
+    edit = (WEdit *) find_widget_type (h, (callback_fn) edit_callback);
     edit_bar = find_buttonbar (h);
 
     widget_set_size (&edit->widget, 0, 0, LINES - 1, COLS);
@@ -151,7 +151,7 @@ edit_dialog_callback (Dlg_head *h, dlg_m
 	return MSG_HANDLED;
 
     case DLG_VALIDATE:
-	edit = (WEdit *) find_widget_type (h, edit_callback);
+	edit = (WEdit *) find_widget_type (h, (callback_fn) edit_callback);
 	if (!edit_ok_to_exit (edit)) {
 	    h->running = 1;
 	}
--- mc/src/view.c.jj	2004-09-02 17:48:19.000000000 +0200
+++ mc/src/view.c	2004-09-02 18:24:52.880496346 +0200
@@ -2606,7 +2606,7 @@ view_adjust_size (Dlg_head *h)
     WButtonBar *bar;
 
     /* Look up the viewer and the buttonbar, we assume only two widgets here */
-    view = (WView *) find_widget_type (h, view_callback);
+    view = (WView *) find_widget_type (h, (callback_fn) view_callback);
     bar = find_buttonbar (h);
     widget_set_size (&view->widget, 0, 0, LINES - 1, COLS);
     widget_set_size (&bar->widget, LINES - 1, 0, 1, COLS);
--- mc/src/menu.c.jj	2004-09-02 17:48:19.000000000 +0200
+++ mc/src/menu.c	2004-09-02 18:15:57.180148318 +0200
@@ -634,8 +634,8 @@ destroy_menu (Menu *menu)
 #ifdef UTF8
     g_free (menu->wentries);
 #endif
-    g_free (menu->name);
-    g_free (menu->help_node);
+    g_free ((char *) menu->name);
+    g_free ((char *) menu->help_node);
     g_free (menu);
 }
 
--- mc/src/widget.c.jj	2004-09-02 18:21:36.000000000 +0200
+++ mc/src/widget.c	2004-09-02 18:24:36.582377062 +0200
@@ -2356,7 +2356,7 @@ find_buttonbar (Dlg_head *h)
 {
     WButtonBar *bb;
 
-    bb = (WButtonBar *) find_widget_type (h, buttonbar_callback);
+    bb = (WButtonBar *) find_widget_type (h, (callback_fn) buttonbar_callback);
     return bb;
 }
 
--- mc/vfs/vfs.c.jj	2004-09-02 11:09:01.000000000 +0200
+++ mc/vfs/vfs.c	2004-09-02 18:08:16.157516731 +0200
@@ -85,7 +85,7 @@ vfs_cmp_handle (gconstpointer a, gconstp
 {
     if (!a)
 	return 1;
-    return ((struct vfs_openfile *) a)->handle != (int) b;
+    return ((struct vfs_openfile *) a)->handle != (long) b;
 }
 
 /* Find VFS class by file handle */
@@ -95,7 +95,7 @@ vfs_op (int handle)
     GSList *l;
     struct vfs_openfile *h;
 
-    l = g_slist_find_custom (vfs_openfiles, (void *) handle,
+    l = g_slist_find_custom (vfs_openfiles, (void *) (long) handle,
 			     vfs_cmp_handle);
     if (!l)
 	return NULL;
@@ -112,7 +112,7 @@ vfs_info (int handle)
     GSList *l;
     struct vfs_openfile *h;
 
-    l = g_slist_find_custom (vfs_openfiles, (void *) handle,
+    l = g_slist_find_custom (vfs_openfiles, (void *) (long) handle,
 			     vfs_cmp_handle);
     if (!l)
 	return NULL;
@@ -128,7 +128,7 @@ vfs_free_handle (int handle)
 {
     GSList *l;
 
-    l = g_slist_find_custom (vfs_openfiles, (void *) handle,
+    l = g_slist_find_custom (vfs_openfiles, (void *) (long) handle,
 			     vfs_cmp_handle);
     vfs_openfiles = g_slist_delete_link (vfs_openfiles, l);
 }