Re: patch: mcview with growing buffers

Hello Roland,

Friday, October 22, 2004, 7:21:05 PM, you wrote:

RI> this patch is quite complex. It fixes these issues:

RI> - WView contained a struct stat that was only partly used (and mostly
RI> abused for _not_ storing file information).
RI> - Error checking using the growing buffer has been added.
RI> - Some variables need an adjustment function called after they are
RI> assigned a new value. This is explicitly documented.
RI> - Some variables have been renamed. For example, char *data is now
RI> accompanied by size_t datasize. A similar change has been applied to the
RI> mmap functions: The variable bytes_read has been used inconsistently and
RI> has been replaced by mmappedsize.
RI> - The function get_byte has become much simpler after factoring out the
RI> growing buffer handling into a separate function.

Please fill out:
[ ] ok to commit
[X] needs review
[ ] rejected

It's candidate for 4.6.2

Best regards,
 Pavel                            mailto:me pavelsh pp ru

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]