Re[2]: Patch for cmd.c
- From: "Pavel Shirshov (pchel)" <me pavelsh pp ru>
- To: "Andrew V. Samoilov" <andrew email zp ua>
- Cc: mc-devel gnome org
- Subject: Re[2]: Patch for cmd.c
- Date: Mon, 25 Oct 2004 15:36:18 +0600
Hello Andrew,
Monday, October 25, 2004, 3:25:24 PM, you wrote:
AVS> Hi,
>>
>> this patch fixes rare and almost impossible off-by-one.
>> If user input is empty (""), these lines can do very bad thing:
>>
>> if (reg_exp_t [strlen(reg_exp_t) - 1] == PATH_SEP){
>> dirflag = 1;
>> reg_exp_t [strlen(reg_exp_t) - 1] = 0;
>> }
>>
>> It is almoust impossible to meet PATH_SEP before '\0', but sometimes it happens.
AVS> Patch attached, sorry for inconvenience.
Committed. Thx
--
Best regards,
Pavel mailto:me pavelsh pp ru
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]