Re: [patch] TODO for 4.6.1: ./file in tar archive

Hello Roland,

> this patch fixes the second TODO item for 4.6.1. It is not perfect, but 
> it works. We should do much more error checking at this point, for 
> example for "../file" or similar things. Therefore we should use a 
> function like canonicalize_pathname from src/utilunix.c.

Have you checked the source paths? I think canonicalize_pathname is
already used and might be the cause of this little problem. I might be
wrong though ;) .

>  We cannot use 
> that function because of license issues (utilunix.c is GPL, vfs is LGPL) 
> and dependency conflicts (src uses vfs, so vfs cannot use src; see ld(1) 
> for further information).

If this _really_ is a problem it might be worth discussing if vfs needs
to be relicensed as GPL according to paragraph 3 from the LGPL:

"3. You may opt to apply the terms of the ordinary GNU General Public
License instead of this License to a given copy of the Library."

However I hope to avoid such license nitpicking if possible.


mount -t life -o ro /dev/dna /genetic/research

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]