Re: bug with large files

[Jindrich Novy <jnovy redhat com>]

Hello Nerijus,

On Wed, 2004-11-24 at 03:38 +0200, Nerijus Baliunas wrote:
> Hello,
> 
> # ls -l
> -rw-r--r--  1 root root 34708799325 Nov 23 06:20 backup01.tar.gz
> -rw-r--r--  1 root root 31964606217 Nov 22 06:09 backup02.tar.gz
> 
> In the mc panel I see:
> 
> backup01.tar.gz     33101M Nov 23 06:20
> backup02.tar.gz     30484M Nov 22 06:09
> 
> But, when I try to copy backup01.tar.gz to backup02.tar.gz, in
> a 'Target file "./backup02.tar.gz" already exists!' dialog I see:
> 
> Source date: Nov 23 06:20, size 349060957
> Target date: Nov 22 06:09, size 1899835145
> 
> mc from cvs snapshot of 2004-11-04 from
> http://www.ibiblio.org/pub/Linux/utils/file/managers/mc/snapshots/
> (btw, why snapshots stopped being generated at that date?).
> 
> Regards,
> Nerijus

The following patch fixes it.

greetings,
Jindrich

-- 
Jindrich Novy <jnovy redhat com>, http://people.redhat.com/jnovy/

--- mc-4.6.1-20041124/src/filegui.c.badsize	2004-11-08 21:10:33.000000000 +0100
+++ mc-4.6.1-20041124/src/filegui.c	2004-11-24 09:51:14.330852896 +0100
@@ -525,8 +525,13 @@
     N_("&No"), BY - 2, 37, REPLACE_NO}, {
     N_("&Yes"), BY - 2, 28, REPLACE_YES}, {
     N_("Overwrite this target?"), BY - 2, 4, 0}, {
-    N_("Target date: %s, size %d"), 6, 4, 0}, {
-    N_("Source date: %s, size %d"), 5, 4, 0}
+#if defined(_FILE_OFFSET_BITS) && _FILE_OFFSET_BITS == 64
+    N_("Target date: %s, size %lu"), 6, 4, 0}, {
+    N_("Source date: %s, size %lu"), 5, 4, 0}
+#else
+    N_("Target date: %s, size %u"), 6, 4, 0}, {
+    N_("Source date: %s, size %u"), 5, 4, 0}
+#endif
 };
 
 #define ADD_RD_BUTTON(i)\
@@ -635,9 +640,9 @@
     ADD_RD_LABEL (ui, 11, 0, 0);
 
     ADD_RD_LABEL (ui, 12, file_date (ui->d_stat->st_mtime),
-		  (int) ui->d_stat->st_size);
+		  (off_t) ui->d_stat->st_size);
     ADD_RD_LABEL (ui, 13, file_date (ui->s_stat->st_mtime),
-		  (int) ui->s_stat->st_size);
+		  (off_t) ui->s_stat->st_size);
 }
 
 void