Re: uglydir patch


On Fri, 12 Nov 2004, Leonard den Ottolander wrote:

> With changelog entries this time.

This patch is IMO not ready to be checked-in in its current state.
The main concern is the second hunk - several points:

1) The return value of read (), which is stored in `rbytes' is not checked
   against -1, a perfectly valid return value.

2) The second call to read() introduced in this patch could hang since
   the pipe is blocking and the first read () could drain the pipe.

3) The patch assumes that the first read () will read everything up to
   and including the '\n' in the dir name, but this is not guaranteed.

I think these are important points and need to be addresed or proven
wrong before this patch is commited. Maybe the original author should
comment on the issue.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]