Re: strippwd patch against CVS20041108

[Jindrich Novy <jnovy redhat com>]

Hello Andrew,

On Wed, 2004-11-10 at 11:51, Andrew V. Samoilov wrote:
> Hello,
> 
> > LdO> These are the hunks of the strippwd patch that have not yet been
> > LdO> committed.
> > 
> >      Committed with my fixes.
> 
> Patch below fixes double free, memory leaks and missed {}.
> Also it introduces new enum to do add2hotlist() calls more readable.
> 
> Second part is optimization.

About the (add2hotlist_cmd): Eliminate static label_string:

I implemented the label_string to be static in order to your comment #16
on Red Hat bugzilla:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=131088

where you replied to my question where the label_string is leaked in my
original implementation of strippwd patch (where label_string is
g_strdup()ed):

AVS >label_string is leaked if input_dialog() returns NULL or empty
string.
AVS >In last case this memory (g_strdup("")) is also leaked.

>From the patch I see you reintroduced this. Otherwise please make it
clear to me.
 
-- 
Jindrich Novy <jnovy redhat com>, http://people.redhat.com/jnovy/