Re: smbfs_open(): Implement O_APPEND via smbfs_lseek()



Andrew V. Samoilov wrote:
Hello,

any complains/side effects?

In the POSIX standard O_APPEND guarantees atomical (seek && write). Your patch would not guarantee this. From a theoretical point of view we should rather rewrite copy_file_file() to be able to handle these files (unless it is already able to do so) than to weaken the guarantee of O_APPEND.

Roland



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]