Re: crash when entering some .tar files

["Andrew V. Samoilov" <andrew email zp ua>]

> Hello Andrew,
> 
> 
> On Tue, 2 Mar 2004 16:48:37 +0200 (EET) "Andrew V. Samoilov" <andrew email zp ua> wrote:
> 
> > > I'm happily using mc for ages (currently 4.6.1-pre1 compiled from sources,
> > > linux 2.4.24 x86, glibc 2.2.5), and encountering now a crash when entering
> > > some kind of .tar files. The error follows:
> > > 
> > > (process:12769): GLib-CRITICAL **: file gstrfuncs.c: line 232 (g_strconcat): assertion `string1 != NULL' failed
> > > 
> > > 
> > > I was not able to access to the mailing list archives yet, is this a known
> > > issue or should I submit a URL to such .tar file (mostly contains files only,
> > > for instance /lib content)?
> > > BTW, GNU tar --version says: 1.13.25.
> > 
> > Submit URL to such .tar please or we would appreciate a stack trace. 
> 
> Yep, you will find the crashing .tar.bz2 (.tar would be enough, but I crunched
> it for bandwidth purposes) here:
> 	http://nanabozo.free.fr/tmp/mc/test.tar.bz2

Well, patch attached.
Thanks for report!

-- 
Regards,
Andrew V. Samoilov.

vfs/ChangeLog:

	* direntry.c (vfs_s_resolve_symlink): Check vfs_s_fullpath()
	return value.

--- vfs/direntry.c	Fri Jan 30 01:12:01 2004
+++ vfs/direntry.c	Thu Mar  4 18:28:01 2004
@@ -217,9 +217,11 @@ vfs_s_resolve_symlink (struct vfs_class 
     /* make full path from relative */
     if (*linkname != PATH_SEP) {
 	char *fullpath = vfs_s_fullpath (me, entry->dir);
-	fullname = g_strconcat (fullpath, "/", linkname, NULL);
-	linkname = fullname;
-	g_free (fullpath);
+	if (fullpath) {
+	    fullname = g_strconcat (fullpath, "/", linkname, NULL);
+	    linkname = fullname;
+	    g_free (fullpath);
+	}
     }
 
     target =

Scanned by evaluation version of Dr.Web antivirus Daemon 
http://drweb.ru/unix/