Re: shell quoting unified



Hi,

On Thu, 2004-08-19 at 18:53, Leonard den Ottolander wrote:
> On Thu, 2004-08-19 at 18:44, Roland Illig wrote:
> > sub foofs_copyin
> > {
> > 	my ($archive, $filename) = shell_quote(@_);
> > 	$filename = shell_quote($filename); # double-quoted
> > }
> 
> Please do not use this. One of the issues I did not address before is
> the fact that in the case of open(FILEOUT, "> $destfile") the variable
> should *not* be quoted.

What of course I meant to say is don't use the
my ($archive, $filename) = shell_quote(@_);
construct where it is not appropriate. You could of course use it where
all parameters need to be quoted. And the second form is alright.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]