Re: Some patches for mc

[Pavel Roskin <proski gnu org>]

Hi, Philipp!

> > Here are some patches for mc that SuSE has been applying for some time now
> > and which could possibly be included in the official mc:
>
> Any status on these?

Sorry, I'm getting much more patches than I can process.  There is a patch
manager on savannah.gnu.org to make sure that the patches don't get lost:

https://savannah.gnu.org/patch/?group=mc

I'm looking at your patches right now.

mc-4.5.51-palmsupport.patch:

It's too specific to a certain device.  The menu doesn't scale well, so
it's better to have only entries useful for many users.  I don't think
I'll apply it unless the menu code is redesigned in some way.  Patch for
making the menu entries translatable is pending.  That's another reason
it's better to keep the menu short - the entries will be translated, so
every entry is additional work.

mc-4.6.0-asmsyntax.patch:

Basically the same problems - too device-specific and the Syntax file
doesn't scale well.  There is no way to switch between different highlight
modes while in the editor, so if you are editing an assembly file for some
other architecture, the highlighting will look wrong.  Besides, some
keywords are missing.  In particular, I don't see "daa" (Decimal Adjust
the contents of Accumulator).  I would be more inclined to apply a syntax
file that is complete.

mc-4.6.0-tempfile.patch:

I don't understand what's the point in creating any temporary files under
/tmp for sending mail.  I think the home directory is suited better for
that purpose.

mc-4.6.0-x11browser.diff

You forgot to attach the script.  By the way, if Mozilla is the default
browser and the file is called "www.foo.com", will "x11browser
www.foo.com" load that file in Mozilla?  If it doesn't work, please fix it
first.

-- 
Regards,
Pavel Roskin