Re: File copy related bugs

[Pavel Roskin <proski gnu org>]

Hello again!

> +	* filegui.c (check_progress_buttons): Reinitialize ret_value to
> +	avoid old values after incomplete events.

I just realized that it should be "Reinitialize ret_value to avoid old
values after events other than selecting a button."

Comment fixed.

> > 3. Why copy dialog buttons are different for different
> >    'Verbose operation' modes? I mean, 'Abort' button is not presented if
> >    'Verbose operation' is disabled. Well, just found, that it is here
> >    actually, but not displayed, untill you press right arrow...

That was non-trivial, but I was lucky to find it fast.

==========================
--- ChangeLog
+++ ChangeLog
@@ -2,2 +2,7 @@
 
+	* dlg.c (init_dlg): Redraw screen after selecting the focused
+	widget, not before.  The bug affected file progress dialog with
+	verbose operation off.
+	Reported by Dmitry Semyonov <Dmitry Semyonov oktet ru>
+
 	* filegui.c (check_progress_buttons): Reinitialize ret_value to
--- dlg.c
+++ dlg.c
@@ -770,12 +770,13 @@ void init_dlg (Dlg_head *h)
     /* Initialize the mouse status */
     h->mouse_status = MOU_NORMAL;
 
-    /* Redraw the screen */
-    dlg_redraw (h);
-
+    /* Select the first widget that takes focus */
     while (!dlg_focus (h) && h->current)
 	h->current = h->current->next;
 
+    /* Redraw the screen */
+    dlg_redraw (h);
+
     h->ret_value = 0;
     h->running = 1;
 }
==========================

-- 
Regards,
Pavel Roskin