Re: ftpfs upload and temporary files



On Tue, 19 Jun 2001, Frédéric L. W. Meunier wrote:

> Hi. Is this really needed ? I noticed all uploaded files are
> copied to /tmp as ftpfs*

Probably not. The temp file is created in vfs_s_open(), file direntry.c.
It is closed and then reopened. This alone is strange and dangerous if
/tmp is not sticky (stoneage UNIX?).

I don't see any logic in vfs_s_open() to avoid this procedure when the
file is on a local filesystem.

Anyway, be happy that MC doesn't crash, hang, run "rm -rf" neither
remotely nor locally. MC is even careful to remove that file (which is
not the case for tgz files opened in fish).

There are more urgent problems than optimization in VFS. Of course, a
nice-looking well-documented patch will be applied if you make one.

-- 
Regards,
Pavel Roskin





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]