Re: [sigc] ANNOUNCE: libsigc++ 2.0.2



On Sat, 2004-05-29 at 12:12 -0700, Timothy M. Shead wrote:
> Christof Petig wrote:
> > Martin Schulze schrieb:
> > 
> >> *** Changes:
> >>
> >> 2.0.2:
> >>
> >> * Suppress compiler warning in compatibility module at
> >>  dynamic_cast<>-test (fix suggested by Timothy M. Shead).
> > 
> > 
> > The warning only changed ("unused variable" -> "statement with no 
> > effect"). Perhaps casting to void might silence the compiler.
> 
> Enclosed is a patch for object_slot.h to eliminate the "statement with 
> no effect" warning.  As Christof suggested, it does a C-style cast to 
> void to eliminate the warning.  Tested on Gentoo x86, gcc 3.3.2.
> 

It looks like you are patching a generated file. You probably want to
patch one of the .m4 files. Making a cvs patch would double-check this.
For instance, see "How do I create a patch?" here:
http://www.gtkmm.org/bugs.shtml

Also, I would add a comment in the code saying why the cast is there.

-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]