Re: [sigc] TypeTraits



Am 31.07.2004 13:28:08 schrieb(en) martin-ml hippogriff de:
> On Thu, 2004-07-29 at 17:02 +0200, Martin Schulze wrote:
>> Hi Arnaud!
>>
>> Thanks for reporting this! You are right, the instance() method is
>> completely ununsed. It was needed for some early alpha versions of
>> libsigc++2 that used gcc's non-portable typeof() keyword. I never
>> thought of removing it.
>>
>> The problem is: formally, the type_trait<> template is part of the
>> public API so I hesitate to silently remove the instance() method.
On
>> the hand, it doesn't really make sense to conditionally generate it
-
>> our only alternative.
>>
>> So, I'm asking the list: is there anybody against completely
removing
>> the (internally unused) type_trait<>::instance() method?
>
> I see no problem with removing it. It is a static method (so, non-
> virtual, so it won't affect ABI), and it is completely
unimplemented, so
> there is no way that anybody could even link to it.

Okay, patches are welcome :-)
Otherwise, I'll try to get the time to do this tomorrow evening.

type_trait<>::instance() is now removed in cvs.

BTW, we still need a patch that adds and uses a pre-generated sigc+ +config.h in the MSVC project directory and adds the SIGC_API keyword!

Regards,

 Martin



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]