Re: [PATCH 1/2] Append Content-Language on Accept-Language request

[Jens Georg <mail jensge org>]

On Do, 2011-05-26 at 15:34 +0300, Zeeshan Ali (Khattak) wrote:
> On Thu, 2011-05-26 at 11:14 +0200, Jens Georg wrote:
> > On Mi, 2011-05-25 at 11:34 +0100, Burton, Ross wrote:
> > > On 25 May 2011 11:18, Sven Neumann <s neumann raumfeld com> wrote:
> > > > Does it make sense to hard-code "en" here? This is the handler for all
> > > > documents that the GUPnPContext serves, right? These documents might as
> > > > well not be English, right? Perhaps there should be a property on
> > > > GUPnPContext that allows to change the language returned here. And that
> > > > property should probably default to "en" then.
> > 
> > Yes, you're right. Thing is that there is no context available in the
> > http handler there and I wouldn't want to add a reference to the context
> > to the HostPathData since that looks cyclish.
> 
>   Why can't you just put the prop's value in the HostPathData?

That's quite a lot of adding, copying, taking care of updating them. Ok,
I assume this information is rather static.