Re: [PATCH 2/2] Sanity check for @restricted DIDL attribute

["Zeeshan Ali (Khattak)" <zeeshanak gnome org>]

Hi,

On Fri, Jun 10, 2011 at 2:49 PM, Santakivi Topi
<Topi Santakivi digia com> wrote:
> +                else if (GUPNP_IS_DIDL_LITE_ITEM (object)) {
> +                        node = gupnp_didl_lite_object_get_xml_node(object);
> +                        if (!gupnp_didl_lite_parser_verify_didl_attributes(node)) {
> +                            g_object_unref (object);
> +                            g_object_unref (xml_doc);
> +                            g_set_error (error,
> +                                         GUPNP_XML_ERROR,
> +                                         GUPNP_XML_ERROR_PARSE,

  We really should add a more specific error (e.g
GUPNP_XML_ERROR_INVALID_ATTRIBUTE) and use that here.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124