Re: createClass API in gupnp-av



Hi,

Understood. Let's just go with your idea of adding _full variants of the functions then.

Jens Georg <mail jensge org> wrote:

>On Fr, 2011-06-03 at 23:57 +0300, Zeeshan Ali (Khattak) wrote:
>> On Fri, Jun 3, 2011 at 11:15 AM, Jens Georg <mail jensge org> wrote:
>> > Hi,
>> >
>> > apparently upnp:createClass@includeDerived is mandatory. The current
>> > code doesn't include it at all.
>> >
>> > While the adding case is easy to fix API-friendly by add_create_class
>> > setting default value for it and add add_create_class_full which allows
>> > to specify the desired value. That would already satisfy our current
>> > needs with Rygel.
>> 
>>   I think at the time of adding this API, my thought was that we'll
>> always set this to "0". Do we get any practical problems with that
>> approach?
>> 
>
>No, we don't. In Rygel we currently treat it like that. So just setting
>it to "0" would be enough from your POV? The only problem we have
>currently is that the current code doesn't set it at all.
>
>Doesn't solve the "get" case though for control points.
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]