Re: [PATCH] Append Content-Language on Accept-Language request
- From: Jens Georg <mail jensge org>
- To: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
- Cc: gupnp-list gnome org
- Subject: Re: [PATCH] Append Content-Language on Accept-Language request
- Date: Sat, 04 Jun 2011 09:52:51 +0200
On Sa, 2011-06-04 at 00:46 +0300, Zeeshan Ali (Khattak) wrote:
> Hi,
>
> On Wed, Jun 1, 2011 at 6:05 PM, Jens Georg <mail jensge org> wrote:
> > This is not mandated by HTTP RFC's but the UPnP CTT requires this.
>
> Looks good except that I don't really like the idea of
> g_object_get/set() here as use of that almost always implies you are
> doing something wrong.
>
> How about putting this value in HostPathData?
Well with that if you set it you need to loop through all the
HostPathData and change it. And as far as I see it, if you want
different languages per HostPath, you just host a file "foo.xml" and add
files like "foo.xml.fi" etc. So there's no benefit in the per hosted
path book-keeping, just more to do if someone changes the default (which
I doubt anyone will do).
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]