Re: Rygel transcoding (results of GSOC 2011)

[Olivier Crête <olivier crete collabora co uk>]

On Thu, 2011-08-25 at 13:00 -0700, David Wendt JR. wrote:
> 1. I wrote a new Gst plugin called "Transcodebin" which abstracts the existing Rygel.Transcoder autoplugging logic, so that it's now just a matter of connecting a sink and source to transcodebin and setting the profile property. This will have to be run by some of the Gstreamer maintainers, and it is -very much- subject to change, but you can see the status of GstTranscodeBin here[1].

A couple comments on the GStreamer bit.

First, GStreamer style:
1. Don't use c++ style declarations (put all declarations at the top of
a block)
2. only prefix with gst_transcode_bin_* the methods of the object, so
for stuff like signal callbacks, don't use the prefix
3. You may want to run the whole thing through gst-indent (from the
common/ directory)
4. Use GST_DEBUG/GST_WARNING/GST_ERROR instead of g_debug
5. You may like GST_DEBUG_PAD_NAME() for debug things
6. I'm not sure why you put base init at the end of the file?

Otherwise, it looks fine.

-- 
Olivier Crête
olivier crete collabora com