Re: [gupnp] [PATCH] Use G_VALUE_NOCOPY_CONTENTS flag with G_VALUE_COLLECT()

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

Hi Sven,

On Tue, May 25, 2010 at 10:16 AM, Sven Neumann <s neumann raumfeld com> wrote:
> On Wed, 2010-05-19 at 22:42 +0200, Sven Neumann wrote:
>> Since we are using the collected value in place and unsetting it
>> directly after, there is no need to actually copy contents to it.
>> This saves some needless string copies.
>>
>> Signed-off-by: Sven Neumann <s neumann raumfeld com>
>
> Please consider this patch for inclusion. It really makes a difference
> for some actions, like for example when replying to a Browse request and
> passing a large DIDL-Lite XML fragment to gupnp_service_action().
>
> We are using this patch for some days now on our beta-test installations
> and it seems to work nicely.

  Thanks! I just pushed it (along with your latest gupnp-av patches)
to official repos (they're moved to gitorious btw).

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com