Re: [gupnp] [PATCH] Flag string argument of GSSDPClient::message-received as static
- From: "Zeeshan Ali (Khattak)" <zeenix gmail com>
- To: gupnp o-hand com
- Subject: Re: [gupnp] [PATCH] Flag string argument of GSSDPClient::message-received as static
- Date: Tue, 6 Jul 2010 19:20:30 +0300
On Tue, Jul 6, 2010 at 6:01 PM, Sven Neumann <s neumann raumfeld com> wrote:
> On Tue, 2010-07-06 at 15:34 +0200, Sven Neumann wrote:
>> Set the G_SIGNAL_TYPE_STATIC_SCOPE flag on the "from_ip" string
>> argument of the GSSDPClient::message-received signal.
>
> This change saves a few string copies on signal emissions. A very minor
> optimization, I have to admit...
An optimization nevertheless. :) Committed & merged. Thanks!
One side note: not that its a big deal or anything if you don't it
but please try to keep the summary line of commit under 50 characters
as per git conventions.
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]