Re: [PATCH] Fix __asm__ __const__ in glib-1.2.x branch

[Owen Taylor <otaylor redhat com>]

Pavel Roskin <proski gnu org> writes:

> Hello!
> 
> If you ever release glib 1.2.11, it would be a shame if this warning is 
> still not fixed.  glib.h uses "__asm__ __const__", which makes no sense, 
> and gcc 3.2 (and some older versions) complains whenever those macros are 
> used.  The warnings in displayed by default, without any "-W" options.
> 
> Example from GNU Midnight Commander (GUINT16_SWAP_LE_BE is used):
> 
> cpio.c: In function `cpio_read_bin_head':
> cpio.c:260: warning: const qualifier ignored on asm
> 
> This is already fixed in glib 2.0.  The attached patch removes __const__
> and realigns backslashes.

A) Patches for GLib should be filed in bugzilla.gnome.org 
   (this is bug #73308, so best to just attach it there, I'm
   not really sure a patch is that useful for this one, but 
   it can't hurt.) Instructions are in the Glib README.

B) It's quite unlikely that we'll ever release GLib-1.2.11.
   mc should be ported to GLib-2.x. (Should be trival assuming
   you've dumped gmc.)

Regards,
                                        Owen