bug fixes

[Seth Lytle <lytles alphatech com>]

I have found a bug in gtklayout, and checked the faq at
http://gtk.org/faq/gtkfaq-3.html#ss3.2
and followed the directions, submitting the patch and a readme to 
ftp://ftp.gtk.org/incoming
and the patch has since been moved to ftp://ftp.gtk.org/pub/gtk/patches, as
predicted by the faq.

However, in spite of there being many patches in /patches from the
latter half of 1999, there doesn't appear to be any patches on which
action has been taken (moved to applied, unapplied, etc) since about
July 1999.

Have I taken the correct actions, or has the procedure for submitting
a patch been changed. The readme and patch follow.

Thanks,
Seth Lytle

-------------------------------------------------------------------

I am submitting a patch to gtk+ vs gtk+1.2.3. I realize this is old,
but I have additionally checked the patches (1.2.6 vs 1.2.3), and
the variables I am changing are not mentioned in them.

The bug:
struct GtkLayout has the following two elements:
  guint xoffset;
  guint yoffset;
as unsigned int, but the rest of the code seems to treat them as 
signed. eg. (highly abreviated)

gtk_layout_adjustment_changed (GtkAdjustment *adjustment,GtkLayout *layout) {
  layout->xoffset = (gint)layout->hadjustment->value;
  layout->yoffset = (gint)layout->vadjustment->value;
}

casts a float (layout->hadjustment->value) to gint before assigning to 
xoffset. other programs, eg. gnome canvas are capable of excercising
the bug.

The patch is very simple. It changes xoffset/yoffset from guint to gint
in gtklayout.h

hope this helps, and that i haven't missed anything.

seth
lytles@neaccess.com

-------------------------------------------------------------------

--- gtk+-1.2.3/gtk/gtklayout.h	Wed Feb 24 05:15:10 1999
+++ gtk+-1.2.3_local/gtk/gtklayout.h	Thu Jan 20 14:46:36 2000
@@ -56,8 +56,8 @@
   guint width;
   guint height;
 
-  guint xoffset;
-  guint yoffset;
+  gint xoffset;
+  gint yoffset;
 
   GtkAdjustment *hadjustment;
   GtkAdjustment *vadjustment;