Re: Error when using VaxStation as terminal

[Owen Taylor <otaylor redhat com>]

Kevin Handy <kth@srv.net> writes:

> I am using a VaxStation 3100 (GPX) as an X-terminal to a
> RedHat Linux box, and have found that the 'clist' widget
> will crash consistantly, usually with an error like the
> following:
> 
> Gdk-ERROR **: BadValue (integer parameter out of range for operation)
>    serial 560 error_code 2 request code 61 minor code 0
> 
> Going through all of the programs in the example directory
> of gtk+-1.2.2 all work except for the 'clist' and the
> 'filesel' examples (which I'm guessing uses clist).
> 
> What does clist do that would cause a crash when none of
> the other widgets seem to have a problem?

CList is doing some strange things with gdk_clear_area
calls, that might be triggering that. Can you try out
the following patch and see if it helps?

Thanks,
                                        Owen

Index: gtkclist.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkclist.c,v
retrieving revision 1.156.2.5
diff -u -r1.156.2.5 gtkclist.c
--- gtkclist.c	1999/04/14 23:33:04	1.156.2.5
+++ gtkclist.c	1999/04/21 18:47:37
@@ -4725,6 +4725,7 @@
   GtkCList *clist;
   gint border_width;
   GdkRectangle child_area;
+  gint width, height;
   int i;
 
   g_return_if_fail (widget != NULL);
@@ -4751,7 +4752,8 @@
 		       (2 * widget->style->klass->ythickness) +
 		       clist->column_title_area.height);
 
-      gdk_window_clear_area (clist->clist_window, 0, 0, -1, -1);
+      gdk_window_get_size (clist->clist_window, &width, &height);
+      gdk_window_clear_area (clist->clist_window, 0, 0, width, height);
       draw_rows (clist, NULL);
 
       for (i = 0; i < clist->columns; i++)
@@ -5944,8 +5946,15 @@
     }
 
   if (!area)
-    gdk_window_clear_area (clist->clist_window,
-			   0, ROW_TOP_YPIXEL (clist, i), -1, -1);
+    {
+      gint width, height;
+      
+      gdk_window_get_size (clist->clist_window, &width, &height);
+      gdk_window_clear_area (clist->clist_window, 0,
+			     ROW_TOP_YPIXEL (clist, i),
+			     width,
+			     height - ROW_TOP_YPIXEL (clist, i));
+    }
 }
 
 static void