Re: [BUG 1.1.1] scrollable notebook arrows

[Lars Hamann <lars gtk org>]

On Wed, Sep 30, 1998 at 04:32:53PM +0200, Juergen A. Erhard wrote:

> SYMPTOMS:
> 
>   Start testgtk, go to the notebook example.  Now make it scrollable.
>   Okay... why's the left arrow active?  Click on it... it jumps to the
>   last page.  Keep the arrow pressed... it stops at the first page.
> 
> WHY'S THIS A BUG?
> 
>   Well, that should be bleedin' obvious, yeh bollicks![1]
> 
>   I mean, the arrows should always behave the same way, no matter
>   whether it's already been open for a couple hours or we just opened
>   it.  Consistency.

They behave the same way. As long as no tab has the focus, both arrows
are active. You'll get the same state if you switch through the tabs
by keyboard. E.g. activate tab one, press cursor left.
Maybe this behaviour is a bit ugly, but the way it is now is the normal
gtkcontainer focus model. I.e. it's a legal state to have no actual
focus tab (notebook->focus_tab == NULL). In this state both arrows are
sensitive.
 
> WHAT TO DO?
> 
>   I looked at the code... and I got to odd feeling that this is
>   deliberate.  Then I diff'd it with the 1.0.4 source...
> 
>   Can anyone (Owen?) tell me why this was done?  Excuse me, but the
>   way it is now is bullsh*t!

Make a consistent proposal and I'll fix it.

>   And there's nothing in the ChangeLog, nil.

Sat Jul 18 00:54:01 1998  Lars Hamann  <lars@gtk.org>

	* gtk/gtknotebook.c (gtk_notebook_set_child_arg): added support for
	CHILD_ARG_MENU_LABEL, CHILD_ARG_TAB_LABEL
	(gtk_notebook_get_child_arg): added support for CHILD_ARG_MENU_LABEL,
	CHILD_ARG_POSITION
	(gtk_notebook_reorder_child): new funktion to change position of a
	notebook page
	(gtk_notebook_draw_arrow): draw left/right arrow with
	GTK_SHADOW_ETCHED_IN if focus_tab is first/last tab.
	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

bye,
  Lars