[PATCH] bug in gdkwindow.c



Hi,

I found a small bug in gdkwindow.c (gtk+-1.0.4). Here's the patched
version ('children' was not checked != NULL before passed to XFree ()):

--- gdkwindow.c Mon May  4 00:16:44 1998
+++ gdkwindow.c.new     Fri Jul  3 10:40:06 1998
@@ -456,7 +456,8 @@
   /* FIXME: This is pretty expensive. Maybe the caller should supply
    *        the parent */
   XQueryTree (gdk_display, anid, &root, &parent, &children, &nchildren);
-  XFree (children);
+  if (children)
+    XFree (children);
   private->parent = gdk_xid_table_lookup (parent);
 
   parent_private = (GdkWindowPrivate *)private->parent;


Regards,

Ullrich
-- 
Ullrich Hafner           <hafner@informatik.uni-wuerzburg.de>
Department of Computer Science, University Wuerzburg, Germany
URL:  http://www-info2.informatik.uni-wuerzburg.de/staff/ulli



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]