Re: [gtk-list] [patch] GtkNotebook

[Tim Janik <Tim Janik Hamburg Netsurf DE>]

On Fri, 30 Jan 1998, Lars Hamann wrote:

> Hi !
> 
> We just uploaded the patch gtk-hamann_jeske-980130-0.patch.gz to ftp.gimp.org.
> It fixes some bugs and adds new features to the GtkNotebook widget.
> The patch is against gtk+-0.99.3.

cool

> 
> [FIX] (gtk_notebook_size_request) :
>    container border width > 0 doesn't work correctly in case of "show_tabs"
> 
> [FIX] (gtk_notebook_pages_allocate) :
>    container border width > 0 doesn't work correctly in case of 
>    GTK_POS_BOTTOM / GTK_POS_RIGHT

this is a problem with other widgets as well, from the TODO:
 * Display of GtkToggleButton is messed up if GtkContainer::container_width
   is greate than 0. GtkCheckButton and GtkRadioButton are only messed up
   if draw_indicator is FALSE.


> [FIX] (gtk_notebook_page_allocate) :
>    the tab label is sized too big (by CHILD_SPACING)
>    e.g. GTK_POS_TOP : 
>       tab_label->allocation.height was
>       tab_label->requisition.height + CHILD_SPACING

shouldn't that be a parameter that can be specified as a widget argument?

> [FIX] (gtk_notebook_remove_page) :
>     call gtk_notebook_switch_page if "cur_page" is removed

this should be done in gtk_notebook_insert_page also,
actually the signal needs to be emitted in all places where cur_page is
assigned a new value i.e.
gtk_notebook_insert_page,
gtk_notebook_remove_page and
gtk_notebook_current_page.
also the switch_page signal should be extended to also pass the page number,
because the notebooks interface i.e.
void       gtk_notebook_remove_page     (GtkNotebook      *notebook,
                                         gint              page_num);
void       gtk_notebook_set_page        (GtkNotebook      *notebook,
                                         gint              page_num);
expects page numbers and not page pointers:
  void (* switch_page)       (GtkNotebook *notebook,
                              GtkNotebookPage *page,
			      gint	       page_num);


> Some suggestions :
> 
> - How about a popup menu on the tab section for quick page switching ?
>   This could be done by an additional "gchar *" parameter to 
>   gtk_notebook_append_page, insert_page, prepend_page. This string will
>   appear in the popup, describing the contents of the page.

why couldn't this string just be the notebook label?

> - As the properties "scrollable", "show_tabs", "show_border" are 
>   separate styles, how about combining gtk_notebook_set_show_tabs,
>   set_show_border, set_scrollable into one function gtk_notebook_set_style,
>   taking an enum as argument ?

a "widget-style" is already something else, look at gtkwidget.[hc] and
gtkstyle.[hc] to see what *_set_style is used for.

> - Should gtk_notebook_foreach be expanded to also iterate over the
>   tab label widgets ? These are certainly also children of the
>   container...

hm, this issue is a little bit tricky.
gtkwidget.c relies on certain behaviours on the container_foreach
functions, and i'm not sure gtknotebook fits that either way...

thanx for the submission.

> 
> bye,
>   Lars + Stefan
> 

---
ciaoTJ