Re: Very small bug in gdk_gc_copy()

[Owen Taylor <owt1 cornell edu>]

Jon Trowbridge <trow@emccta.com> writes:

> The problem is with line 655 of gdkgc.c, the last real line of code in the
> file.  It says:
> 
> XCopyGC (src_private->xdisplay, src_private->xgc, 0xffff, dst_private->xgc);
> 
> The 0xffff is not sufficient to make sure that all components of the
> GC actually get copied.  Replacing it with 0xffffffff clears up the
> problem under Linux on the Intel.  I don't actually know anything
> about X, though, so I don't know if this is portable...

I think it should be OK. There is a _small_ chance that a server could
be implemented in such a way that that would give a BadValue error
(there are only 22 defined flags), but I think that is fairly
unlikely. I've made the change.

Thanks,
                                        Owen