Re: [PATCH] Not yet applied?

[johannes nada kth se (Johannes Keukelaar)]

//
//johannes@nada.kth.se (Johannes Keukelaar) writes:
//
//> Why hasn't my patch gtk-johannes-980329-0-patch been applied yet in 0.99.10?
//
//I haven't applied the part with the layout of the buttons in the
//standard dialogs, because fiddling with the UI layout isn't a high
//priority, and the change to right-justify them wasn't mine anyways.
//
//My personal opinion is that right justifying for OK/cancel looks good,
//but the fileops buttons should be spread instead of left
//justified. (Shawn wanted the left-justified squished together fileops
//buttons to look like a toolbar)

Well, I don't agree. :) (I sent in the patch because I thought it was a 
mistake, not something intentional.) What to do about such things?

//The second part, with testgtk and destroy and delete events, wasn't
//applied because it isn't correct. Currently, the code is:
//
//  gtk_signal_connect (GTK_OBJECT (window), "destroy",
//		      GTK_SIGNAL_FUNC(gtk_main_quit),
//		      NULL);
//  gtk_signal_connect (GTK_OBJECT (window), "delete_event",
//		      GTK_SIGNAL_FUNC (gtk_false),
//		      NULL);
//
//That is, "On a delete_event, return FALSE to say that we haven't
//handled the event, so go ahead and destroy the window". "On
//a destroy event, quit the main loop". The delete_event handler
//could be removed, since that is simply the default action, but
//the current code _is_ correct.
//
//Perhaps the problem you thought existed was the mainloop test?
//I rewrote it for 0.99.10 so it should be a bit nicer.

Well, in 0.99.9, clicking on the testgtk window's delete button (the wm one), 
makes the window go away, but the app keeps running. I figured that was a bug. 
:) In 0.99.10, however, things work properly, i.e. clicking the delete button 
makes the window go away _and_ the app quit.

So, I'm happy about the second item. Not quite about the first item. What do 
other people think about this alignment-thing?

//Regards,
//                                        Owen

Regards,

Johannes.
--
There are two classes of people: Those who divide people into classes, and 
those who don't.

Self-professed nerd of Mathematics and Computer Science.